DEADripER commented on code in PR #12547: URL: https://github.com/apache/ignite/pull/12547#discussion_r2610551524
########## modules/core/src/main/java/org/apache/ignite/internal/management/checkpoint/CheckpointTask.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.management.checkpoint; + +import java.util.List; +import java.util.concurrent.TimeUnit; +import org.apache.ignite.IgniteException; +import org.apache.ignite.compute.ComputeJobResult; +import org.apache.ignite.internal.GridKernalContext; +import org.apache.ignite.internal.processors.cache.persistence.CheckpointState; +import org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager; +import org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointProgress; +import org.apache.ignite.internal.util.typedef.internal.CU; +import org.apache.ignite.internal.visor.VisorJob; +import org.apache.ignite.internal.visor.VisorMultiNodeTask; +import org.jetbrains.annotations.Nullable; + +/** Checkpoint task. */ +public class CheckpointTask extends VisorMultiNodeTask<CheckpointCommandArg, String, String> { + /** */ + private static final long serialVersionUID = 0; + + /** {@inheritDoc} */ + @Override protected VisorJob<CheckpointCommandArg, String> job(CheckpointCommandArg arg) { + return new CheckpointJob(arg, false); + } + + /** {@inheritDoc} */ + @Override protected @Nullable String reduce0(List<ComputeJobResult> results) throws IgniteException { + for (ComputeJobResult res : results) { + if (res.getException() != null) + throw res.getException(); + } + + return "Checkpoint triggered on all nodes"; + } + + /** Checkpoint job. */ + private static class CheckpointJob extends VisorJob<CheckpointCommandArg, String> { + /** */ + private static final long serialVersionUID = 0; + + /** */ + protected CheckpointJob(CheckpointCommandArg arg, boolean debug) { + super(arg, debug); + } + + /** {@inheritDoc} */ + @Override protected String run(CheckpointCommandArg arg) throws IgniteException { Review Comment: +, thank you for refactoring ########## modules/core/src/main/java/org/apache/ignite/internal/management/checkpoint/CheckpointCommandArg.java: ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.management.checkpoint; + +import java.io.IOException; +import java.io.ObjectInput; +import java.io.ObjectOutput; +import org.apache.ignite.internal.dto.IgniteDataTransferObject; +import org.apache.ignite.internal.management.api.Argument; +import org.apache.ignite.internal.util.typedef.internal.U; + +/** Checkpoint command arguments. */ +public class CheckpointCommandArg extends IgniteDataTransferObject { + /** */ + private static final long serialVersionUID = 0; + + /** */ + @Argument(description = "Reason for checkpoint", optional = true) + private String reason; + + /** */ + @Argument(description = "Wait for checkpoint to finish", optional = true) + private boolean waitForFinish; + + /** */ + @Argument(description = "Timeout in milliseconds", optional = true) + private Long timeout; Review Comment: + ########## modules/core/src/main/java/org/apache/ignite/internal/management/checkpoint/CheckpointCommand.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.management.checkpoint; + +import java.util.Collection; +import java.util.function.Consumer; +import org.apache.ignite.cluster.ClusterNode; +import org.apache.ignite.internal.management.api.CommandUtils; +import org.apache.ignite.internal.management.api.ComputeCommand; +import org.jetbrains.annotations.Nullable; + +/** Checkpoint command. */ +public class CheckpointCommand implements ComputeCommand<CheckpointCommandArg, String> { + /** {@inheritDoc} */ + @Override public Class<CheckpointTask> taskClass() { + return CheckpointTask.class; + } + + /** {@inheritDoc} */ + @Override public String description() { + return "Trigger checkpoint with optional parameters"; + } + + /** {@inheritDoc} */ + @Override public Class<CheckpointCommandArg> argClass() { + return CheckpointCommandArg.class; + } + + /** {@inheritDoc} */ + @Override public @Nullable Collection<ClusterNode> nodes( Review Comment: + -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
