Vladsz83 commented on code in PR #12581:
URL: https://github.com/apache/ignite/pull/12581#discussion_r2619892163
##########
modules/core/src/main/java/org/apache/ignite/internal/direct/DirectMessageWriter.java:
##########
@@ -345,6 +346,17 @@ public ByteBuffer getBuffer() {
return stream.lastFinished();
}
+ /** {@inheritDoc} */
+ @Override public <T> boolean writeSet(Set<T> set,
MessageCollectionItemType itemType) {
+ DirectByteBufferStream stream = state.item().stream;
+
+ // There is no need to use set under the hood. Elemets are via the
ierator with the order provided.
Review Comment:
A test will fail. One which checks the reader and writer types. Also is for
the similarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
