wernerdv commented on code in PR #12554:
URL: https://github.com/apache/ignite/pull/12554#discussion_r2622742742
##########
modules/codegen2/src/main/java/org/apache/ignite/internal/MessageSerializerGenerator.java:
##########
@@ -142,6 +148,8 @@ private String generateSerializerCode(String serClsName)
throws IOException {
try (Writer writer = new StringWriter()) {
writeClassHeader(writer, PKG_NAME, serClsName);
+ writeClassFields(writer);
Review Comment:
I suggest adding a check:
```
if (!fields.isEmpty())
writeClassFields(writer);
```
Otherwise, if fields is empty, there will be an empty line before the first
method `writeTo`, and our plugin will complain about it: `Illegal empty line
before first class element `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
