ptupitsyn commented on code in PR #7261:
URL: https://github.com/apache/ignite-3/pull/7261#discussion_r2629763772
##########
modules/platforms/dotnet/Apache.Ignite/Internal/ClientFailoverSocket.cs:
##########
@@ -385,6 +408,74 @@ internal IEnumerable<ClientSocket> GetSockets()
return res;
}
+ private async Task InitEndpointsAsync(int lockWaitTimeoutMs =
Timeout.Infinite)
+ {
+ bool lockAcquired = await
_socketLock.WaitAsync(lockWaitTimeoutMs).ConfigureAwait(false);
Review Comment:
Changed to a separate lock. We want to avoid multiple re-resolve operations
running in parallel, so we need a lock for the entire duration of re-resolve.
For example, when topology changes, we might receive multiple events of
assignment change and socket disconnect rapidly. A lock with a timeout ensures
we don't re-resolve too many times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
