shishkovilja commented on code in PR #12572:
URL: https://github.com/apache/ignite/pull/12572#discussion_r2635468421
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java:
##########
@@ -87,13 +110,57 @@ public void order(long order) {
}
/** @return Socket addresses list for redirect. */
- @Nullable public Collection<InetSocketAddress> redirectAddresses() {
- return redirectAddresses;
+ public @Nullable Collection<InetSocketAddress> redirectAddresses() {
+ return redirectAddrs;
+ }
+
+ /** @param sockAddrs Socket addresses list for redirect. */
+ public void redirectAddresses(@Nullable Collection<InetSocketAddress>
sockAddrs) {
+ redirectAddrs = sockAddrs;
+ }
+
+ /** @return Collection of {@link InetAddressMessage}. */
+ public @Nullable Collection<InetAddressMessage>
redirectAddressesMessages() {
Review Comment:
I suggest to move such trasformations to corresponding methods, which
applies `InetSocketAddress` collections.
See my suggestion above.
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java:
##########
@@ -55,17 +78,17 @@ public TcpDiscoveryHandshakeResponse(UUID creatorNodeId,
long locNodeOrder) {
* @return previous node alive flag.
*/
public boolean previousNodeAlive() {
- return getFlag(CHANGE_TOPOLOGY_FLAG_POS);
Review Comment:
`CHANGE_TOPOLOGY_FLAG_POS` can be safely removed now.
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java:
##########
@@ -87,13 +110,57 @@ public void order(long order) {
}
/** @return Socket addresses list for redirect. */
- @Nullable public Collection<InetSocketAddress> redirectAddresses() {
- return redirectAddresses;
+ public @Nullable Collection<InetSocketAddress> redirectAddresses() {
+ return redirectAddrs;
Review Comment:
```suggestion
return F.isEmpty(redirectAddrsMsgs) ? null :
F.transform(redirectAddrsMsgs, msg -> {
try {
return new InetSocketAddress(msg.address(), msg.port());
}
catch (UnknownHostException e) {
throw new IgniteException("Failed to read host
address.", e);
}
});
```
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryHandshakeResponse.java:
##########
@@ -87,13 +110,57 @@ public void order(long order) {
}
/** @return Socket addresses list for redirect. */
- @Nullable public Collection<InetSocketAddress> redirectAddresses() {
- return redirectAddresses;
+ public @Nullable Collection<InetSocketAddress> redirectAddresses() {
+ return redirectAddrs;
+ }
+
+ /** @param sockAddrs Socket addresses list for redirect. */
+ public void redirectAddresses(@Nullable Collection<InetSocketAddress>
sockAddrs) {
+ redirectAddrs = sockAddrs;
Review Comment:
```suggestion
redirectAddrsMsgs = sockAddrs == null ? null :
F.viewReadOnly(sockAddrs, addr -> new
InetAddressMessage(addr.getAddress(), addr.getPort()));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
