korlov42 commented on code in PR #7303:
URL: https://github.com/apache/ignite-3/pull/7303#discussion_r2650898368
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExchangeServiceImpl.java:
##########
@@ -177,13 +188,21 @@ private void onMessage(InternalClusterNode node,
QueryBatchMessage msg) {
try {
inbox.onBatchReceived(node.name(), msg.batchId(), msg.last(),
msg.rows());
} catch (Throwable e) {
- inbox.onError(e);
+ Throwable toUse;
+ //noinspection InstanceofCatchParameter
+ if (e instanceof ExpressionEvaluationException) {
Review Comment:
extracted this `if` statement to `convertEvaluationException` helper method
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlToRelConvertor.java:
##########
@@ -139,6 +140,31 @@ public SqlNode validateExpression(RelDataType rowType,
SqlNode expr) {
throw new UnsupportedOperationException("Not implemented yet");
}
+ /**
+ * Converts given AST representing expression to a {@link RexNode
relational expression tree}.
+ *
+ * @param node The AST root to convert.
+ * @param scope The scope to use to resolve column reference, if any.
+ * @param inputRowType The input row type. Should be provided if
expression contains any column references.
+ * @return A converted expression tree.
+ */
+ public RexNode convertExpressionExt(SqlNode node, SqlValidatorScope scope,
@Nullable RelDataType inputRowType) {
+ //
Review Comment:
thanks, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
