denis-chudov commented on code in PR #7304:
URL: https://github.com/apache/ignite-3/pull/7304#discussion_r2650906004
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/handlers/TxCleanupRecoveryRequestHandler.java:
##########
@@ -34,6 +34,7 @@
import org.apache.ignite.internal.logger.IgniteLogger;
Review Comment:
There are also log messages mentioned in the ticket but not changed here:
- `Failed to acquire a lock`
- `Transaction is already finished` (changed only in InternalTableImpl)
This will require changes in HeapLockManager, ReadWriteTransactionImpl,
InflightTransactionalOperationTracker, PartitionReplicaListener, maybe
somewhere else.
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/handlers/TxCleanupRecoveryRequestHandler.java:
##########
@@ -152,7 +153,7 @@ private CompletableFuture<?> callCleanup(TxMeta txMeta,
UUID txId) {
txMeta.commitTimestamp(),
txId
).exceptionally(throwable -> {
- LOG.warn("Failed to cleanup transaction [txId={}].", throwable,
txId);
+ LOG.warn("Failed to cleanup transaction [{}].", throwable,
TransactionLogUtils.formatTxInfo(txId, txManager));
Review Comment:
it's better to use static method imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
