ibessonov commented on code in PR #7248:
URL: https://github.com/apache/ignite-3/pull/7248#discussion_r2675906421
##########
modules/network/src/main/java/org/apache/ignite/internal/network/recovery/HandshakeManagerUtils.java:
##########
@@ -88,4 +92,19 @@ static Exception
createExceptionFromRejectionMessage(HandshakeRejectedMessage ms
? new RecipientLeftException(msg.message())
: new HandshakeException(msg.message());
}
+
+ static void maybeFailOnStaleNodeDetection(
+ FailureProcessor failureProcessor,
+ StaleNodeHandlingParams local,
+ StaleNodeHandlingParams remote
+ ) {
+ long localTopologyVersion = local.topologyVersion();
+ long remoteTopologyVersion = remote.topologyVersion();
+
+ if (localTopologyVersion >= remoteTopologyVersion) {
+ return;
+ }
+
+ failureProcessor.process(new
FailureContext(FailureType.CRITICAL_ERROR, null, "Node is segmented."));
Review Comment:
> does the offending node just get stuck unable to connect to anybody?
Yes. No-op failure handler only makes sense for testing imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
