nizhikov commented on code in PR #12626:
URL: https://github.com/apache/ignite/pull/12626#discussion_r2685464669
##########
modules/binary/api/src/main/java/org/apache/ignite/internal/binary/BinaryClassDescriptor.java:
##########
@@ -781,7 +781,7 @@ void write(Object obj, BinaryWriterExImpl writer) throws
BinaryObjectException {
break;
case BINARY_ENUM:
- writer.writeBinaryEnum((BinaryEnumObjectImpl)obj);
+ writer.writeBinaryEnum((BinaryObjectEx)obj);
Review Comment:
We want to expose only binary-api in writer.
And BinaryEnumObjectImpl is not public api and will be moved to binary-impl
module.
> it can broke smth if assertions are disabled
`BinaryObject#ordinal` throws for non enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
