Copilot commented on code in PR #7396:
URL: https://github.com/apache/ignite-3/pull/7396#discussion_r2685722510
##########
.github/workflows/python_dbapi_wheels.yml:
##########
@@ -65,8 +65,7 @@ jobs:
modules/platforms/
- uses: actions/setup-python@v6
- with:
- python-version: 3.11
+ # Do not specify a concrete version of python here as it causes
cibuildwheel to link a DLL for the wrong version of python on Windows
Review Comment:
Removing the python-version specification affects all platforms in the build
matrix (macOS, Ubuntu, Windows), not just Windows. This could lead to
inconsistent behavior if different runners have different default Python
versions. Consider using a conditional approach to only omit the version for
Windows builds, or document that this change affects all platforms and explain
why it's acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
