ibessonov commented on code in PR #7361:
URL: https://github.com/apache/ignite-3/pull/7361#discussion_r2686422091
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -957,20 +963,32 @@ public boolean onSnapshotLoad(SnapshotReader reader) {
/** {@inheritDoc} */
@Override
public void onShutdown() {
+ if (raftMetrics != null) {
+ raftMetrics.onLeaderStopped(nodeId);
+ }
+
listener.onShutdown();
Review Comment:
This component already has listeners. Please explain why you had to hardcode
explicit dependency instead of reusing them. Converting a single listener into
a list of listeners would be better imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
