ptupitsyn commented on code in PR #5836:
URL: https://github.com/apache/ignite-3/pull/5836#discussion_r2707698601
##########
modules/api/src/main/java/org/apache/ignite/table/KeyValueView.java:
##########
@@ -300,17 +575,54 @@ public interface KeyValueView<K, V> extends
DataStreamerTarget<Entry<K, V>>, Cri
*/
boolean remove(@Nullable Transaction tx, K key);
+ /**
+ * Removes from a table a value associated with the given key.
+ *
+ * @param key Key whose value is to be removed from the table. The key
cannot be {@code null}.
+ * @return {@code True} if a value associated with the specified key was
successfully removed, {@code false} otherwise.
+ * @throws MarshallerException if the key doesn't match the schema.
+ */
+ default boolean remove(K key) {
+ return remove(null, key);
+ }
+
/**
* Removes from a table an expected value associated with the given key.
+ * Deprecated: use {@link #removeExact(Transaction, Object, Object)}
instead.
*
* @param tx Transaction or {@code null} for implicit transaction.
* @param key Key whose value is to be removed from the table. The key
cannot be {@code null}.
* @param val Expected value.
* @return {@code True} if the expected value for the specified key was
successfully removed, {@code false} otherwise.
* @throws MarshallerException if the key and/or the value doesn't match
the schema.
*/
+ @Deprecated(forRemoval = true)
boolean remove(@Nullable Transaction tx, K key, V val);
+ /**
+ * Removes from a table an expected value associated with the given key.
+ *
+ * @param key Key whose value is to be removed from the table. The key
cannot be {@code null}.
+ * @param val Expected value.
+ * @return {@code True} if the expected value for the specified key was
successfully removed, {@code false} otherwise.
+ * @throws MarshallerException if the key and/or the value doesn't match
the schema.
+ */
+ default boolean removeExact(@Nullable Transaction tx, K key, V val) {
+ return remove(null, key, val);
Review Comment:
```suggestion
return remove(tx, key, val);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
