ptupitsyn commented on code in PR #7449:
URL: https://github.com/apache/ignite-3/pull/7449#discussion_r2712198455
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java:
##########
@@ -98,7 +98,8 @@ public class ClientHandlerModule implements IgniteComponent,
PlatformComputeTran
ProtocolBitmaskFeature.SQL_DIRECT_TX_MAPPING,
ProtocolBitmaskFeature.TX_CLIENT_GETALL_SUPPORTS_TX_OPTIONS,
ProtocolBitmaskFeature.SQL_MULTISTATEMENT_SUPPORT,
- ProtocolBitmaskFeature.COMPUTE_OBSERVABLE_TS
+ ProtocolBitmaskFeature.COMPUTE_OBSERVABLE_TS,
+ ProtocolBitmaskFeature.TX_DIRECT_MAPPING_SEND_REMOTE_WRITES
Review Comment:
I agree with @korlov42 . Direct mapping is buggy without
`TX_DIRECT_MAPPING_SEND_REMOTE_WRITES`, so if
`TX_DIRECT_MAPPING_SEND_REMOTE_WRITES` is not supported by the client, the
entire direct mapping feature should be disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
