arcolight commented on code in PR #7487:
URL: https://github.com/apache/ignite-3/pull/7487#discussion_r2735626359
##########
modules/platforms/cpp/cmake/ignite_install_headers.cmake:
##########
@@ -19,10 +19,10 @@
#
# Function to install header files.
function(ignite_install_headers)
- cmake_parse_arguments(IGNITE_INSTALL "" "DESTINATION" "FILES" ${ARGN})
+ cmake_parse_arguments(IGNITE_INSTALL "" "DESTINATION" "FILES;COMPONENT"
${ARGN})
Review Comment:
Not necessary, theoretically header files could be used in multiple
components. For example, if we will provide separate libraries, protocol, for
example, we will need to install headers for it as well as for client. I'd
prefer to keep this parameter with multiple values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
