adityamukho commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2753151922


##########
modules/network/src/main/java/org/apache/ignite/internal/network/CriticalStripedExecutors.java:
##########
@@ -51,11 +53,15 @@ class CriticalStripedExecutors implements ManuallyCloseable 
{
             String poolNamePrefix,
             CriticalWorkerRegistry workerRegistry,
             ChannelTypeRegistry channelTypeRegistry,
-            IgniteLogger log
+            IgniteLogger log,
+            @Nullable MetricManager metricManager,

Review Comment:
   `CriticalStripedExecutors` may be used outside of the messaging service in 
the future, and metrics may not be so important elsewhere as to be made 
mandatory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to