ibessonov commented on code in PR #7455:
URL: https://github.com/apache/ignite-3/pull/7455#discussion_r2757459515
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -681,6 +683,8 @@ grpId, hexLong(pageId)
if (waitUntilPageIsFullyInitialized) {
waitUntilPageIsFullyInitialized(resPointer);
}
+
+ metrics.recordPageAcquireTime(System.nanoTime() - startTime);
Review Comment:
The execution of this `finally` block does not guarantee that the page had
been acquired. Here in particular we can determine that an acquisition happened
by checking for `waitUntilPageIsFullyInitialized` like in the statement above.
Doing it without a check would falsely report a shorter amount of time from
time to time.
We can rename `waitUntilPageIsFullyInitialized` to something like
`acquireHappened` to be more transparent about its new more broad meaning I
suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
