ac1d0globlya commented on code in PR #12677:
URL: https://github.com/apache/ignite/pull/12677#discussion_r2758675440
##########
modules/codegen2/src/main/java/org/apache/ignite/internal/idto/IgniteDataTransferObjectProcessor.java:
##########
@@ -107,28 +112,27 @@ private void generateSingle(Element el) {
return;
TypeMirror dtoCls =
processingEnv.getElementUtils().getTypeElement(DTO_CLASS).asType();
- TypeMirror argAnnotation =
processingEnv.getElementUtils().getTypeElement(ARG_ANNOTATION).asType();
TypeElement clazz = (TypeElement)el;
// Generate code for inner classes.
clazz.getEnclosedElements().forEach(this::generateSingle);
+ if (unsupported.contains(clazz.getQualifiedName().toString()))
+ return;
+
if (!processingEnv.getTypeUtils().isAssignable(clazz.asType(), dtoCls))
return;
if (clazz.getModifiers().contains(Modifier.ABSTRACT))
return;
- if (!clazz.getModifiers().contains(Modifier.PUBLIC))
+ if (clazz.getModifiers().contains(Modifier.PRIVATE) &&
clazz.getModifiers().contains(Modifier.PROTECTED))
Review Comment:
You are commenting code part thats filter out classes, not fields.
Can you, please, clarify the question and proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
