alex-plekhanov commented on code in PR #12675:
URL: https://github.com/apache/ignite/pull/12675#discussion_r2759642253
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteScalarFunction.java:
##########
@@ -26,28 +26,41 @@
* Implementation of {@link ScalarFunction} for Ignite user defined functions.
*/
public class IgniteScalarFunction extends IgniteReflectiveFunctionBase
implements ScalarFunction {
+ /** */
+ private boolean deterministic;
+
/**
* Private constructor.
*/
- private IgniteScalarFunction(Method method, CallImplementor implementor) {
+ private IgniteScalarFunction(Method method, CallImplementor implementor,
boolean deterministic) {
super(method, implementor);
+
+ this.deterministic = deterministic;
Review Comment:
Test added.
What do you mean by the mock?
JavaDoc for public QuerySqlFunction annotation? I think it's already
contains all required information. This annotation used for both query engines,
so it's not correct to describe behavour for one of this engine in JavaDoc.
Also this behavior can be extended later, for example if Calcite allow to
change deterministic flag for SqlUserDefinedFunction class this flag will be
processed also by Calcite and we can't control (and desrcibe on any change) all
usages of this flag in Calcite code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
