sk0x50 commented on code in PR #7428:
URL: https://github.com/apache/ignite-3/pull/7428#discussion_r2764109829
##########
modules/transactions/src/test/java/org/apache/ignite/internal/tx/metrics/TransactionMetricSourceTest.java:
##########
@@ -61,7 +61,8 @@ void testMetricNames() {
"RoCommits",
"RoRollbacks",
"RwDuration",
- "RoDuration");
+ "RoDuration",
+ TransactionMetricsSource.METRIC_PENDING_WRITE_INTENTS);
Review Comment:
I would avoid using a constant in this particular test. The main goal is to
check that the list of metrics contains all required metrics and that metric
names are correct. Let's assume that I changed the name `pendingWriteIntents`
to `pendingWriteIntentы` by accident. In that case, the test will not fail, and
so will not highlight the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
