Lalant commented on code in PR #7517:
URL: https://github.com/apache/ignite-3/pull/7517#discussion_r2767611572
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/handlers/FinishTxCommandHandler.java:
##########
@@ -122,24 +127,14 @@ private static List<EnlistedPartitionGroup>
fromPartitionMessages(List<EnlistedP
return list;
}
- private static void onTxStateStorageCasFail(UUID txId, TxMeta
txMetaBeforeCas, TxMeta txMetaToSet) {
- String errorMsg = format("Failed to update tx state in the storage,
transaction txId = {} because of inconsistent state,"
+ private static void logTxStateStorageCasFail(UUID txId, TxMeta
txMetaBeforeCas, TxMeta txMetaToSet) {
+ String errorMsg = format("Finish command skipped, transaction txId =
{} because of inconsistent state,"
+ " expected state = {}, state to set = {}",
Review Comment:
Done
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/handlers/FinishTxCommandHandler.java:
##########
@@ -122,24 +127,14 @@ private static List<EnlistedPartitionGroup>
fromPartitionMessages(List<EnlistedP
return list;
}
- private static void onTxStateStorageCasFail(UUID txId, TxMeta
txMetaBeforeCas, TxMeta txMetaToSet) {
- String errorMsg = format("Failed to update tx state in the storage,
transaction txId = {} because of inconsistent state,"
+ private static void logTxStateStorageCasFail(UUID txId, TxMeta
txMetaBeforeCas, TxMeta txMetaToSet) {
+ String errorMsg = format("Finish command skipped, transaction txId =
{} because of inconsistent state,"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
