ibessonov commented on code in PR #7534:
URL: https://github.com/apache/ignite-3/pull/7534#discussion_r2768695990
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -734,15 +735,20 @@ private CompletableFuture<Void>
prepareTableResourcesOnRecovery(
CatalogSchemaDescriptor schemaDescriptor
) {
return inBusyLockAsync(busyLock, () -> {
- TableImpl table = createTableImpl(causalityToken, tableDescriptor,
zoneDescriptor, schemaDescriptor);
Review Comment:
Oof. No, the reason is justified in this place. In order to create
`RecordBinaryViewImpl` instance in `TableImpl`'s constructor I need all its
fields to be initialized. But `schemaReg` was implemented as a setter. By
removing the setter I changed the order in which objects are allocated in this
code, it forced me to call `createTableImpl` only after the completion of
`schemaManager.schemaRegistry(causalityToken, tableId)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
