solveme commented on code in PR #7488:
URL: https://github.com/apache/ignite-3/pull/7488#discussion_r2784038218
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -163,17 +172,23 @@ public DefaultMessagingService(
this.marshaller = marshaller;
this.criticalWorkerRegistry = criticalWorkerRegistry;
this.failureProcessor = failureProcessor;
+ this.metricManager = metricManager;
outboundExecutor = new CriticalSingleThreadExecutor(
IgniteMessageServiceThreadFactory.create(nodeName,
"MessagingService-outbound", LOG, NOTHING_ALLOWED)
);
+ outboundExecutor.initMetricSource(metricManager,
"network.messaging.executor.outbound",
Review Comment:
Should we register executors under executors metrics category e.g. something
like `thread.pools.striped.messaging.outbound` ?
We have a dedicated definition for thread-pools category:
/** Default source group for a thread pools. */
public static final String THREAD_POOLS_GROUP_NAME = "thread.pools";
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
