NSAmelchev commented on code in PR #12702:
URL: https://github.com/apache/ignite/pull/12702#discussion_r2787006174
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotPartitionsVerifyHandler.java:
##########
@@ -439,13 +440,18 @@ private PartitionHashRecord
calculateDumpedPartitionHash(Dump dump, String folde
}
/** {@inheritDoc} */
- @Override public void complete(String name,
- Collection<SnapshotHandlerResult<Map<PartitionKey,
PartitionHashRecord>>> results) throws IgniteCheckedException {
+ @Override public void complete(
+ String name,
+ Map<UUID, SnapshotHandlerResult<Map<PartitionKey,
PartitionHashRecord>>> results
+ ) throws IgniteCheckedException {
IdleVerifyResult.Builder bldr = IdleVerifyResult.builder();
- for (SnapshotHandlerResult<Map<PartitionKey, PartitionHashRecord>> res
: results) {
+ for (Map.Entry<UUID, SnapshotHandlerResult<Map<PartitionKey,
PartitionHashRecord>>> e : results.entrySet()) {
+ UUID nodeId = e.getKey();
+ SnapshotHandlerResult<Map<PartitionKey, PartitionHashRecord>> res
= e.getValue();
+
if (res.error() != null) {
- bldr.addException(res.node(), res.error());
+ bldr.addException(cctx.discovery().node(nodeId), res.error());
Review Comment:
This case is nearly impossible (the distributed process should cover it).
But even if a node goes down after receiving the results, I now use
historicalNode. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
