xtern commented on code in PR #7532:
URL: https://github.com/apache/ignite-3/pull/7532#discussion_r2787896130
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/externalize/RelJson.java:
##########
@@ -904,6 +918,24 @@ RexNode toRex(RelInput relInput, Object o) {
return rexBuilder.makeLiteral(literal, type, true);
}
+ if (map.containsKey("sargLiteral")) {
+ Object sargObject = map.get("sargLiteral");
+ if (sargObject == null) {
+ final RelDataType type = toType(typeFactory,
map.get("type"));
+ return rexBuilder.makeNullLiteral(type);
+ }
+ final RelDataType type = toType(typeFactory, map.get("type"));
+ Sarg sarg = sargFromJson((Map) sargObject, type);
+ return rexBuilder.makeSearchArgumentLiteral(sarg, type);
+ }
+
+ if (map.containsKey("dynamicParam")) {
Review Comment:
looks like this condition is unreachable until we add similar serialization
for dyn params.
E.g. you added deserialization of dynamic parameter by the `dynamicParam`
key, but we don't use this key when serializing dynamic parameters.
So my suggestion is to remove this condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
