sk0x50 commented on code in PR #7564:
URL: https://github.com/apache/ignite-3/pull/7564#discussion_r2802971071


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZonesUtil.java:
##########
@@ -491,22 +491,18 @@ public static boolean filterNodeAttributes(Map<String, 
String> nodeAttributes, S
      * Filters storage profiles.
      *
      * @param node Node with storage profile attributes.
-     * @param zoneStorageProfiles Zone's storage profiles.
+     * @param zoneStorageProfiles Zone's storage profile names.
      * @return True, if matches, false otherwise.
      */
     public static boolean filterStorageProfiles(
             NodeWithAttributes node,
-            List<CatalogStorageProfileDescriptor> zoneStorageProfiles
+            List<String> zoneStorageProfiles

Review Comment:
   It's a little weird to me. We have changed the exact type to a general one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to