chesnokoff commented on code in PR #12756:
URL: https://github.com/apache/ignite/pull/12756#discussion_r2821836252
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/testframework/junits/IgniteCompatibilityNodeRunner.java:
##########
@@ -106,6 +106,8 @@ public static void main(String[] args) throws Exception {
// It needs to set private static field 'ignite' of the
IgniteNodeRunner class via reflection
GridTestUtils.setFieldValue(new IgniteNodeRunner(), "ignite",
ignite);
+ startParentPipeWatcher(ignite);
Review Comment:
1. Fixed. Added call of `startParentPipeWatcher` because
`delayedDumpClasspath` has timeout
2. I’d keep the two threads separate: `delayedDumpClasspath()` is a
timeout-based startup diagnostics timer (interrupt-cancellable), while
`startParentPipeWatcher()` is an EOF-based parent-liveness watcher on stdin.
Unifying them would add complexity with no clear benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
