ptupitsyn commented on code in PR #7626:
URL: https://github.com/apache/ignite-3/pull/7626#discussion_r2826160895
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTypeCheckMarshallingTest.java:
##########
@@ -87,14 +129,20 @@ void argumentMarshallerDoesNotMatch() {
JobExecution<Integer> result = submit(
JobTarget.node(node(1)),
// The descriptor does not match actual job arguments.
- JobDescriptor.<Integer,
Integer>builder(ArgumentTypeCheckingmarshallingJob.class.getName())
+ JobDescriptor.<Integer,
Integer>builder(ArgumentTypeCheckingMarshallingJob.class.getName())
.argumentMarshaller(new IntegerMarshaller())
.build(),
1
);
await().until(result::stateAsync, willBe(jobStateWithStatus(FAILED)));
- assertResultFailsWithErr(Compute.MARSHALLING_TYPE_MISMATCH_ERR,
result);
+ assertResultFailsWithErr(
+ result, Compute.MARSHALLING_TYPE_MISMATCH_ERR,
+ "Exception in user-defined marshaller",
+ hasMessage(containsString(
+
"org.apache.ignite.marshalling.UnsupportedObjectTypeMarshallingException:
IGN-MARSHALLING-2 "
+ + "Unsupported object type: java.lang.Integer.
Please, define a marshaller that can handle this type."))
Review Comment:
I still think the error message is problematic. Even with your explanation I
can't fully understand it. As a user, what am I supposed to do? How do I fix
the problem?
Marshaller API can be tricky to get right, so our error messages should be
as helpful and details as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
