shishkovilja commented on code in PR #12708: URL: https://github.com/apache/ignite/pull/12708#discussion_r2828262717
########## modules/core/src/main/java/org/apache/ignite/spi/discovery/DiscoverySpiCustomMessage.java: ########## @@ -17,37 +17,28 @@ package org.apache.ignite.spi.discovery; -import java.io.Serializable; +import org.apache.ignite.internal.managers.discovery.DiscoCache; import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage; import org.apache.ignite.internal.managers.discovery.GridDiscoveryManager; -import org.jetbrains.annotations.Nullable; +import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion; +import org.apache.ignite.lang.IgniteUuid; /** * Message to send across ring. * * @see GridDiscoveryManager#sendCustomEvent(DiscoveryCustomMessage) + * TODO: Should be removed in https://issues.apache.org/jira/browse/IGNITE-27778 */ -public interface DiscoverySpiCustomMessage extends Serializable { - /** - * Called when custom message has been handled by all nodes. - * - * @return Ack message or {@code null} if ack is not required. - */ - @Nullable public DiscoverySpiCustomMessage ackMessage(); +@Deprecated +public abstract class DiscoverySpiCustomMessage implements DiscoveryCustomMessage { Review Comment: I think it sounds reasonable. Let's implement it in a tiket: https://issues.apache.org/jira/browse/IGNITE-27778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
