ptupitsyn commented on code in PR #7482:
URL: https://github.com/apache/ignite-3/pull/7482#discussion_r2832146504
##########
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientTransaction.java:
##########
@@ -348,7 +348,7 @@ public static ClientTransaction get(Transaction tx) {
throw new TransactionException(
TX_ALREADY_FINISHED_ERR,
- format("Transaction is already finished [tx={}].", clientTx));
+ format("Transaction is already finished or finishing
[tx={}].", clientTx));
Review Comment:
The message is duplicated all over the place, should we introduce a constant?
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java:
##########
@@ -526,7 +526,7 @@ public static TableNotFoundException
tableIdNotFoundException(Integer tableId) {
// Remote transaction will be synchronously rolled
back if the timeout has exceeded.
if (remote.isRolledBackWithTimeoutExceeded()) {
throw new
TransactionException(TX_ALREADY_FINISHED_WITH_TIMEOUT_ERR,
- "Transaction is already finished [tx="
+ remote + "].");
+ "Transaction is already finished or
finishing [tx=" + remote + "].");
Review Comment:
Here and below, the error message is inconsistent with the error code. The
timeout already happened, what does "finishing" mean? Is it helpful to the user
to see "or finishing" in the error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
