ivanzlenko commented on code in PR #7657:
URL: https://github.com/apache/ignite-3/pull/7657#discussion_r2850976800
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -713,6 +713,7 @@ private ClusterState createClusterState(CmgInitMessage msg,
@Nullable List<UUID>
* <li>Broadcasts the current CMG state to all nodes in the physical
topology.</li>
* </ol>
*/
+ @SuppressWarnings("PMD.UnusedFormalParameter")
Review Comment:
Why we need suppress here?
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/PlacementDriverMessageProcessor.java:
##########
@@ -317,6 +317,7 @@ private CompletableFuture<Void>
waitForActualState(HybridTimestamp startTime, lo
});
}
+ @SuppressWarnings("PMD.UnusedFormalParameter") // term is required by
LeaderElectionListener interface
Review Comment:
Can we just do this raftClient.subscribeLeader((node, term) ->
onLeaderElected(node));
instead of suppression?
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/replacement/PageReplacementPolicy.java:
##########
@@ -43,6 +43,7 @@ protected PageReplacementPolicy(Segment seg) {
*
* @param relPtr Relative pointer to page.
*/
+ @SuppressWarnings("PMD.UnusedFormalParameter")
Review Comment:
Should we create a ticket to refactor this?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -318,6 +318,7 @@ public static BigDecimal toBigDecimal(byte val, int
precision, int scale) {
}
/** CAST(BOOL AS DECIMAL). */
+ @SuppressWarnings("PMD.UnusedFormalParameter")
Review Comment:
Do we actually need this methods?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/TablePartitionProcessor.java:
##########
@@ -107,6 +107,7 @@ public class TablePartitionProcessor implements
RaftTableProcessor {
private ReplicaMeta lastKnownLease;
/** Constructor. */
+ @SuppressWarnings("PMD.UnusedFormalParameter") //
partitionOperationsExecutor kept for API compatibility
Review Comment:
What API?
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTupleSchema.java:
##########
@@ -298,6 +298,7 @@ public Element element(int index) {
*
* @return Column index if the schema is based on a SchemaDescriptor, -1
otherwise.
*/
+ @SuppressWarnings("PMD.UnusedFormalParameter") // index is used by
subclass overrides
Review Comment:
Let's create a ticket to refactor this and introduce some kind of interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
