JAkutenshi commented on code in PR #7507:
URL: https://github.com/apache/ignite-3/pull/7507#discussion_r2872708112
##########
modules/raft-api/src/main/java/org/apache/ignite/internal/raft/service/TimeAwareRaftGroupService.java:
##########
@@ -25,23 +25,28 @@
import org.apache.ignite.internal.raft.Command;
import org.apache.ignite.internal.raft.Peer;
import org.apache.ignite.internal.raft.PeersAndLearners;
-import org.apache.ignite.internal.raft.configuration.RaftConfiguration;
import org.apache.ignite.internal.replicator.ReplicationGroupId;
import org.jetbrains.annotations.Nullable;
/**
- * A service providing operations on a replication group with operations
timeout.
+ * A service providing operations on a replication group with explicit timeout
control.
*
- * <p>Most of operations require a known group leader. The group leader can be
refreshed at any time by calling {@link #refreshLeader()}
- * method, otherwise it will happen automatically on a first call.
+ * <p>Most of operations require a known group leader. The group leader can be
refreshed at any time by calling
+ * {@link #refreshLeader(long)} method, otherwise it will happen automatically
on a first call.
*
* <p>If a leader has been changed while the operation in progress, the
operation will be transparently retried until timeout is reached.
* The current leader will be refreshed automatically (maybe several times) in
the process.
*
- * <p>Each asynchronous method (returning a future) uses a default timeout to
finish, see {@link RaftConfiguration#retryTimeoutMillis()}.
- * If a result is not available within the timeout, the future will be
completed with a {@link TimeoutException}
+ * <p>Each asynchronous method takes a {@code timeoutMillis} parameter with
the following semantics:
+ * <ul>
+ * <li>{@code 0} - single attempt without retries</li>
+ * <li>{@code Long.MAX_VALUE} - infinite wait</li>
+ * <li>negative values - treated as infinite for compatibility</li>
+ * <li>positive values - bounded wait up to the specified timeout</li>
Review Comment:
...Dots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
