shishkovilja commented on code in PR #12754:
URL: https://github.com/apache/ignite/pull/12754#discussion_r2878294573
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageCasAckMessage.java:
##########
@@ -18,26 +18,34 @@
package org.apache.ignite.internal.processors.metastorage.persistence;
import java.util.UUID;
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.managers.discovery.DiscoveryMessageFactory;
import org.apache.ignite.internal.util.typedef.internal.S;
/** */
-class DistributedMetaStorageCasAckMessage extends
DistributedMetaStorageUpdateAckMessage {
+public class DistributedMetaStorageCasAckMessage extends
DistributedMetaStorageUpdateAckMessage {
/** */
private static final long serialVersionUID = 0L;
/** */
- private final boolean updated;
+ @Order(2)
+ boolean updated;
+
+ /** Empty constructor of {@link DiscoveryMessageFactory}. */
+ public DistributedMetaStorageCasAckMessage() {
+ // No-op.
+ }
/** */
- public DistributedMetaStorageCasAckMessage(UUID reqId, String errorMsg,
boolean updated) {
- super(reqId, errorMsg);
+ public DistributedMetaStorageCasAckMessage(UUID reqId, boolean updated) {
+ super(reqId);
this.updated = updated;
}
- /** */
- public boolean updated() {
Review Comment:
Unnecessary change.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java:
##########
@@ -1163,20 +1160,14 @@ private void onAckMessage(
ClusterNode node,
DistributedMetaStorageUpdateAckMessage msg
) {
- GridFutureAdapter<Boolean> fut = updateFuts.remove(msg.requestId());
+ GridFutureAdapter<Boolean> fut = updateFuts.remove(msg.reqId);
Review Comment:
Unneccessary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
