Copilot commented on code in PR #7734:
URL: https://github.com/apache/ignite-3/pull/7734#discussion_r2906606861
##########
modules/platforms/cpp/CMakeLists.txt:
##########
@@ -140,6 +140,7 @@ endif()
if (WIN32)
add_definitions(-DNOMINMAX)
+ set(IGNITE_INSTALL_INCLUDE_DIR include)
else()
include(GNUInstallDirs)
Review Comment:
`IGNITE_INSTALL_INCLUDE_DIR` is hardcoded to `include` only on WIN32. To
keep install layout consistent and user-configurable across platforms (and to
align with `GNUInstallDirs`), consider using `CMAKE_INSTALL_INCLUDEDIR` for
Windows as well (either by using `GNUInstallDirs` on all platforms or by
setting `IGNITE_INSTALL_INCLUDE_DIR` to `${CMAKE_INSTALL_INCLUDEDIR}` in both
branches). If you need a fallback, set it conditionally only when
`CMAKE_INSTALL_INCLUDEDIR` is not defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
