sergey-chugunov-1985 commented on code in PR #12825:
URL: https://github.com/apache/ignite/pull/12825#discussion_r2911084197


##########
modules/core/src/test/java/org/apache/ignite/cache/store/CacheStoreWithIgniteTxFailureTest.java:
##########
@@ -201,6 +200,23 @@ public void testSystemExceptionAfterCacheStoreCommit() 
throws Exception {
         checkKeysOnHealthyNodes(keysOnFaultyNode);
     }
 
+    /** Check client node availability. */
+    private void checkClientIsAvailable() {
+        assertTrue("Client node should survive test scenario",
+            G.allGrids()
+                .stream()
+                .filter(ignite -> ((IgniteEx)ignite).context().clientNode())
+                .count() == 1);
+    }
+
+    /** Check that faulty node is absent in current topology. */
+    private void checkFultyNode(int faultyNodeIdx) {
+        assertTrue("Faulty node should survive test scenario, idx=" + 
faultyNodeIdx,

Review Comment:
   ```suggestion
           assertTrue("Faulty node should not survive test scenario, idx=" + 
faultyNodeIdx,
   ```



##########
modules/core/src/test/java/org/apache/ignite/cache/store/CacheStoreWithIgniteTxFailureTest.java:
##########
@@ -201,6 +200,23 @@ public void testSystemExceptionAfterCacheStoreCommit() 
throws Exception {
         checkKeysOnHealthyNodes(keysOnFaultyNode);
     }
 
+    /** Check client node availability. */
+    private void checkClientIsAvailable() {
+        assertTrue("Client node should survive test scenario",
+            G.allGrids()
+                .stream()
+                .filter(ignite -> ((IgniteEx)ignite).context().clientNode())
+                .count() == 1);
+    }
+
+    /** Check that faulty node is absent in current topology. */
+    private void checkFultyNode(int faultyNodeIdx) {

Review Comment:
   ```suggestion
       private void checkFаultyNodeLeftTopology(int faultyNodeIdx) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to