sk0x50 commented on code in PR #7701:
URL: https://github.com/apache/ignite-3/pull/7701#discussion_r2917517923
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1569,18 +1495,57 @@ private CompletableFuture<Void>
stopTablePartition(TablePartitionId tablePartiti
// In case of colocation there shouldn't be any table replica and thus
it shouldn't be stopped.
minTimeCollectorService.removePartition(tablePartitionId);
+ unregisterPartitionMetrics(tablePartitionId, table.name());
+
+ return mvGc.removeStorage(tablePartitionId);
+ }
+
+ private void registerPartitionTableStatsMetrics(
+ TableViewInternal table,
+ int partitionId,
+ PartitionResources partitionResources
+ ) {
+ PartitionTableStatsMetricSource metricSource =
+ new PartitionTableStatsMetricSource(table.tableId(),
partitionId, partitionResources.modificationCounter);
+
+ try {
+ metricManager.registerSource(metricSource);
+ metricManager.enable(metricSource);
Review Comment:
This metric source was disabled for a reason. Please take a look at
[IGNITE-27813](https://issues.apache.org/jira/browse/IGNITE-27813). I don't
think that we are ready to enable it by default again.
> // Only register this Metrics Source and do not enable it by
default
> // as it is intended for online troubleshooting purposes only.
> metricManager.registerSource(metricSource);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
