ascherbakoff commented on code in PR #7730:
URL: https://github.com/apache/ignite-3/pull/7730#discussion_r2929241920
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientTransactionsTest.java:
##########
@@ -1401,34 +1400,53 @@ public void
testRollbackDoesNotBlockOnLockConflict(KillTestContext ctx) {
assertThat(kvView.removeAllAsync(null, Arrays.asList(key0, key,
key2)), willSucceedFast());
}
- @Test
- @Disabled("https://issues.apache.org/jira/browse/IGNITE-27947";)
- public void testRollbackDoesNotBlockOnLockConflictDuringFirstRequest()
throws InterruptedException {
+ @ParameterizedTest
+ @MethodSource("killTestContextFactory")
+ public void
testRollbackDoesNotBlockOnLockConflictDuringFirstRequest(KillTestContext ctx) {
// Note: reversed tx priority is required for this test.
ClientTable table = (ClientTable) table();
+ ClientSql sql = (ClientSql) client().sql();
Review Comment:
According to the note at line 1406 [1], you need to enable the reversed tx
priority for this test.
This is required to ensure tx2 (younger) waits for locks from tx1 (older).
After switching to WOUND_WAIT [2] this will be the detault behavior.
Otherwise, the test doesn't reproduce anything.
[1]
https://github.com/apache/ignite-3/pull/7730/changes#diff-6764538010ba679d53a71a8c6f2251eda1fd68e73cc1ec932a7ddeefcc573fafL1407
[2] https://issues.apache.org/jira/browse/IGNITE-24963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
