Cyrill commented on code in PR #7527:
URL: https://github.com/apache/ignite-3/pull/7527#discussion_r2939628861
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/handlers/TxStateCommitPartitionReplicaRequestHandler.java:
##########
@@ -115,35 +129,57 @@ public CompletableFuture<TransactionMeta>
handle(TxStateCommitPartitionRequest r
* Checks whether tx recovery is needed with given tx meta and triggers it
of needed.
*
* @param txId Transaction id.
+ * @param tableId Table id.
+ * @param commitGroupId Commit group id.
* @param txStateMeta Transaction meta.
* @param readTimestamp If the recovery is triggered by RO transaction,
the the read timestamp of that transaction,
* otherwise {@code null}.
* @param senderCurrentConsistencyToken See {@link
TxStateCommitPartitionRequest#senderCurrentConsistencyToken()}.
* @param senderGroupId See {@link
TxStateCommitPartitionRequest#senderGroupId()}.
+ * @param rowId Row id.
+ * @param newestCommitTimestamp Newest commit timestamp.
* @return Tx recovery future, or completed future if the recovery isn't
needed, or failed future if the recovery is not possible.
*/
private CompletableFuture<TransactionMeta>
triggerTxRecoveryOnTxStateResolutionIfNeeded(
UUID txId,
+ Integer tableId,
+ ZonePartitionId commitGroupId,
@Nullable TxStateMeta txStateMeta,
@Nullable HybridTimestamp readTimestamp,
@Nullable Long senderCurrentConsistencyToken,
- @Nullable ZonePartitionId senderGroupId,
- UUID senderId
+ ZonePartitionId senderGroupId,
+ UUID senderId,
+ @Nullable RowId rowId,
+ @Nullable HybridTimestamp newestCommitTimestamp
) {
- // The state is either null or PENDING or ABANDONED, other states have
been filtered out previously.
+ // The state is either null or PENDING or ABANDONED, other states have
been filtered out previously.lo
Review Comment:
.lo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
