valepakh commented on PR #7545:
URL: https://github.com/apache/ignite-3/pull/7545#issuecomment-4069226871

   > Two things:
   > 
   > 1. **Logging Supplier instead of its result** — in 
`StaticUnitDeployer.process()`, `infoSupplier` is passed directly to the 
logger. This will log something like `lambda@1234abcd` instead of the actual 
message. Should be `infoSupplier.get()`.
   > 2. **Missing cluster status check before recovery** — 
`checkAndRecoverUnit` only checks that node status is `DEPLOYED`, but doesn't 
verify the cluster-level status. If the cluster status is already `OBSOLETE` or 
`REMOVING`, creating a node status of `UPLOADING` will trigger a download of a 
unit that's being deleted.
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to