shishkovilja commented on code in PR #12780:
URL: https://github.com/apache/ignite/pull/12780#discussion_r2958607107


##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -5859,6 +5859,12 @@ private void 
processMetricsUpdateMessage(TcpDiscoveryMetricsUpdateMessage msg) {
 
             msg = metricsMsgFilter.pollActualMessage(laps, msg);
 
+            // pollActualMessage() can return null when 
actualFirstLapMetricsUpdate or actualSecondLapMetricsUpdate

Review Comment:
   Are there any existiong NPE case?



##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -5859,6 +5859,12 @@ private void 
processMetricsUpdateMessage(TcpDiscoveryMetricsUpdateMessage msg) {
 
             msg = metricsMsgFilter.pollActualMessage(laps, msg);
 
+            // pollActualMessage() can return null when 
actualFirstLapMetricsUpdate or actualSecondLapMetricsUpdate

Review Comment:
   Are there any existing NPE case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to