shishkovilja commented on code in PR #12891:
URL: https://github.com/apache/ignite/pull/12891#discussion_r2960736184
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessage.java:
##########
@@ -216,24 +218,21 @@ public int partition() {
return null;
}
- /**
- * @param marsh Marshaller.
- */
- public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException
{
- if (topic != null && topicBytes == null)
+ /** {@inheritDoc} */
+ @Override public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
+ if (topicOrd < 0 && topic != null && topicBytes == null)
topicBytes = U.marshal(marsh, topic);
}
- /**
- * @param marsh Marshaller.
- * @param ldr Class loader.
- */
- public void finishUnmarshal(Marshaller marsh, ClassLoader ldr) throws
IgniteCheckedException {
- if (topicBytes != null && topic == null) {
+ /** {@inheritDoc} */
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader ldr)
throws IgniteCheckedException {
+ if (topicOrd < 0 && topicBytes != null && topic == null) {
Review Comment:
```suggestion
if (topicOrd < 0 && topicBytes != null) {
```
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java:
##########
@@ -219,31 +217,33 @@ public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
evtsBytes = U.marshal(marsh, evts);
}
- /**
- * @param marsh Marshaller.
- * @param ldr Class loader.
- * @param filterClsLdr Class loader for filter.
- */
- public void finishUnmarshal(Marshaller marsh, ClassLoader ldr, ClassLoader
filterClsLdr) throws IgniteCheckedException {
+ /** {@inheritDoc} */
+ @Override public void finishUnmarshal(Marshaller marsh, ClassLoader ldr)
throws IgniteCheckedException {
if (resTopicBytes != null && resTopic == null) {
Review Comment:
```suggestion
if (resTopicBytes != null) {
```
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/eventstorage/GridEventStorageMessage.java:
##########
@@ -205,10 +205,8 @@ public void loaderParticipants(@Nullable Map<UUID,
IgniteUuid> ldrParties) {
return ErrorMessage.error(errMsg);
}
- /**
- * @param marsh Marshaller.
- */
- public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException
{
+ /** {@inheritDoc} */
+ @Override public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
if (resTopic != null && resTopicBytes == null)
Review Comment:
```suggestion
if (resTopic != null)
```
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/GridIoMessage.java:
##########
@@ -216,24 +218,21 @@ public int partition() {
return null;
}
- /**
- * @param marsh Marshaller.
- */
- public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException
{
- if (topic != null && topicBytes == null)
+ /** {@inheritDoc} */
+ @Override public void prepareMarshal(Marshaller marsh) throws
IgniteCheckedException {
+ if (topicOrd < 0 && topic != null && topicBytes == null)
Review Comment:
```suggestion
if (topicOrd < 0 && topic != null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
