tkalkirill commented on code in PR #12893: URL: https://github.com/apache/ignite/pull/12893#discussion_r2978819323
########## modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/PseudoCacheColumnDescriptor.java: ########## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.query.calcite.schema; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.ignite.IgniteCheckedException; +import org.apache.ignite.IgniteException; +import org.apache.ignite.calcite.PseudoColumnDescriptor; +import org.apache.ignite.calcite.PseudoColumnProvider; +import org.apache.ignite.internal.processors.cache.GridCacheContext; +import org.apache.ignite.internal.processors.cache.persistence.CacheDataRow; +import org.apache.ignite.internal.processors.query.QueryUtils; +import org.apache.ignite.internal.processors.query.calcite.PseudoColumnValueExtractorContextEx; +import org.apache.ignite.internal.processors.query.calcite.exec.ExecutionContext; +import org.apache.ignite.internal.processors.query.calcite.type.IgniteTypeFactory; +import org.apache.ignite.internal.processors.query.calcite.util.TypeUtils; + +import static org.apache.calcite.rel.type.RelDataType.PRECISION_NOT_SPECIFIED; +import static org.apache.calcite.rel.type.RelDataType.SCALE_NOT_SPECIFIED; + +/** Pseudocolumn descriptor for cache tables. */ +class PseudoCacheColumnDescriptor implements CacheColumnDescriptor { + /** */ + private static final ThreadLocal<PseudoColumnValueExtractorContextExImp> VALUE_EXTRACTOR_CTX = ThreadLocal.withInitial( + PseudoColumnValueExtractorContextExImp::new + ); + + /** */ + private final PseudoColumnDescriptor desc; + + /** */ + private final int fieldIdx; + + /** */ + private volatile RelDataType logicalType; + + /** */ + PseudoCacheColumnDescriptor(PseudoColumnDescriptor desc, int fieldIdx) { + if (QueryUtils.KEY_FIELD_NAME.equalsIgnoreCase(desc.name()) + || QueryUtils.VAL_FIELD_NAME.equalsIgnoreCase(desc.name())) { + throw new IgniteException( + String.format("Pseudocolumn name should not overlap with the system ones: [name=%s]", desc.name()) + ); + } + + this.desc = desc; + this.fieldIdx = fieldIdx; + } + + /** {@inheritDoc} */ + @Override public boolean field() { + return false; + } + + /** {@inheritDoc} */ + @Override public boolean key() { + return false; + } + + /** {@inheritDoc} */ + @Override public Object value( + ExecutionContext<?> ectx, + GridCacheContext<?, ?> cctx, + CacheDataRow src + ) throws IgniteCheckedException { + return desc.value(VALUE_EXTRACTOR_CTX.get().update(ectx, cctx, src)); + } + + /** {@inheritDoc} */ + @Override public void set(Object dst, Object val) throws IgniteCheckedException { + throw new UnsupportedOperationException(); + } + + /** {@inheritDoc} */ + @Override public String name() { + return desc.name(); + } + + /** {@inheritDoc} */ + @Override public int fieldIndex() { + return fieldIdx; + } + + /** {@inheritDoc} */ + @Override public RelDataType logicalType(IgniteTypeFactory f) { + if (logicalType == null) { + logicalType = TypeUtils.sqlType( + f, + desc.type(), + desc.precision() != PseudoColumnDescriptor.NOT_SPECIFIED ? desc.precision() : PRECISION_NOT_SPECIFIED, + desc.scale() != PseudoColumnDescriptor.NOT_SPECIFIED ? desc.scale() : SCALE_NOT_SPECIFIED, + true Review Comment: If it is **false**, then the user will be required to add a pseudocolumn when inserting/updating, otherwise an error like this will occur. ``` org.apache.ignite.internal.processors.query.IgniteSQLException: Failed to validate query. From line 1, column 13 to line 1, column 25: Column 'KEY_TO_STRING' has no default value and does not allow NULLs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
