arcolight commented on code in PR #7718: URL: https://github.com/apache/ignite-3/pull/7718#discussion_r2982965694
########## modules/platforms/cpp/cmake/ignite_check_headers.cmake: ########## @@ -0,0 +1,67 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# ignite_check_headers(SOURCE_DIR <dir> PUBLIC <list> PRIVATE <list>) +# +# Configure-time check that every .h file found under SOURCE_DIR belongs to +# exactly one of the PUBLIC or PRIVATE header lists. +# +# Fails with FATAL_ERROR when: +# - A header is not listed in either PUBLIC or PRIVATE. +# - A header is listed in both PUBLIC and PRIVATE. +function(ignite_check_headers) + cmake_parse_arguments(ARGS "" "SOURCE_DIR" "PUBLIC;PRIVATE" ${ARGN}) + + if (NOT ARGS_SOURCE_DIR) + message(FATAL_ERROR "ignite_check_headers: SOURCE_DIR is required") + endif() + + file(GLOB_RECURSE _all_headers RELATIVE "${ARGS_SOURCE_DIR}" "${ARGS_SOURCE_DIR}/*.h") Review Comment: Right, fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
