isapego commented on code in PR #7875:
URL: https://github.com/apache/ignite-3/pull/7875#discussion_r2991347897
##########
modules/platforms/cpp/tests/client-test/main.cpp:
##########
@@ -71,24 +71,28 @@ int main(int argc, char **argv) {
ignite_runner runner;
set_process_abort_handler([&](int signal) {
- std::cout << "Caught signal " << signal << " during tests" <<
std::endl;
+ std::cerr << "Caught signal " << signal << " during tests" <<
std::endl;
runner.stop();
});
if (!check_test_node_connectable(std::chrono::seconds(5))) {
runner.start();
- ensure_node_connectable(std::chrono::seconds(60));
+ auto timeout = std::chrono::minutes(5);
+ if (!check_test_node_connectable(timeout)) {
+ std::cerr << "Failed to start node within timeout: " <<
timeout.count() << "min" << std::endl;
+ return 3;
+ }
Review Comment:
In practice all node start at the same time so it's OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
