alievmirza commented on code in PR #7845:
URL: https://github.com/apache/ignite-3/pull/7845#discussion_r2995816796
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/metrics/MetaStorageMetricSource.java:
##########
@@ -63,7 +75,7 @@ public void onIdempotentCacheSizeChange(int newSize) {
protected class Holder implements AbstractMetricSource.Holder<Holder> {
private final LongMetric safeTimeLag = new LongGauge(
"SafeTimeLag",
- "Number of milliseconds the local MetaStorage SafeTime lags
behind the local logical clock.",
+ "Number of milliseconds the local Meta Storage SafeTime lags
behind the local logical clock.",
Review Comment:
yes, there a lot of usages with space
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/impl/MetaStorageManagerImpl.java:
##########
@@ -214,6 +219,24 @@ public class MetaStorageManagerImpl implements
MetaStorageManager, MetastorageGr
/** Tracks only reads from the leader, local reads are tracked by the
storage itself. */
private final ReadOperationForCompactionTracker
readOperationFromLeaderForCompactionTracker;
+ /** Current Meta Storage voting peers (consistent IDs), updated on each
committed Raft configuration. */
+ private volatile Set<String> currentVotingPeers = Set.of();
+
+ /**
+ * MetaStorage availability flag: 1 if MS majority can execute commands, 0
otherwise.
+ * Updated by the periodic availability check.
+ */
+ private volatile int mgAvailable = 0;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
