Phillippko commented on code in PR #7892:
URL: https://github.com/apache/ignite-3/pull/7892#discussion_r3001010546
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/HybridLogJRaftServiceFactory.java:
##########
@@ -31,41 +30,38 @@
public class HybridLogJRaftServiceFactory extends IgniteJraftServiceFactory {
private final LogStorageManager newStorageManager;
- private final String newStorageRelativePath;
+ private final Path newStoragePath;
/**
* Creates a new instance of HybridLogJRaftServiceFactory for migrating
from old storage type to new one.
* @param oldStorageManager Factory to create old log storages.
* @param newStorageManager Factory to create new log storage.
+ * @param newStoragePath Path used by {@param newStorageManager}. Should be
different from old storage path to avoid conflicts.
*/
public HybridLogJRaftServiceFactory(
LogStorageManager oldStorageManager,
LogStorageManager newStorageManager,
- String newStorageRelativePath
+ Path newStoragePath
) {
super(oldStorageManager);
this.newStorageManager = newStorageManager;
- this.newStorageRelativePath = newStorageRelativePath;
+ this.newStoragePath = newStoragePath;
}
@Override
- public LogStorage createLogStorage(String uri, RaftOptions raftOptions) {
- Requires.requireTrue(StringUtils.isNotBlank(uri), "Blank log storage
uri.");
+ public LogStorage createLogStorage(String groupId, RaftOptions
raftOptions) {
Review Comment:
URI and groupId?
Example of passing **real** URI instead of groupId in NodeImpl:
```
this.logStorage =
this.serviceFactory.createLogStorage(this.options.getLogUri(),
this.raftOptions);
```
It uses DefaultJRaftServiceFactory, not our IgniteJraftServiceFactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
