tkalkirill commented on code in PR #12926:
URL: https://github.com/apache/ignite/pull/12926#discussion_r3022182434
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/schema/CacheIndexImpl.java:
##########
@@ -197,4 +178,59 @@ public Index queryIndex() {
return true;
}
+
+ /** */
+ protected List<SearchBounds> buildSearchBounds(
+ RelOptCluster cluster,
+ RelCollation collation,
+ @Nullable RexNode cond,
+ RelDataType rowType,
+ @Nullable ImmutableBitSet requiredColumns
+ ) {
+ return RexUtils.buildSortedSearchBounds(
+ cluster,
+ collation,
+ cond,
+ rowType,
+ requiredColumns
+ );
+ }
+
+ /** */
+ protected <Row> IndexScan<Row> createIndexScan(
+ ExecutionContext<Row> ectx,
+ ColocationGroup grp,
+ RangeIterable<Row> ranges,
+ @Nullable ImmutableBitSet requiredColumns
+ ) {
+ return new IndexScan<>(
+ ectx,
+ tbl.descriptor(),
+ idx.unwrap(InlineIndex.class),
+ collation.getKeys(),
+ grp.partitions(ectx.localNodeId()),
+ ranges,
+ requiredColumns
+ );
+ }
+
+ /** */
+ protected <Row> IndexScan<Row> createIndexFirstLastScan(
+ boolean first, ExecutionContext<Row> ectx, ColocationGroup grp,
@Nullable ImmutableBitSet requiredColumns
+ ) {
+ return new IndexFirstLastScan<>(
+ first,
+ ectx,
+ tbl.descriptor(),
+ idx.unwrap(InlineIndexImpl.class),
+ collation.getKeys(),
+ grp.partitions(ectx.localNodeId()),
+ requiredColumns
+ );
+ }
+
+ /** */
+ protected CacheIndexImpl copyWithNewTable(IgniteCacheTable newTbl) {
Review Comment:
People in internet are saying that using the name "clone" with arguments
isn't best practice. My intuition agrees with that. I suggest leaving it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
