sashapolo commented on code in PR #7924:
URL: https://github.com/apache/ignite-3/pull/7924#discussion_r3032437531
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/metrics/LocalTopologyMetricsSource.java:
##########
@@ -111,28 +107,22 @@ protected class Holder implements
AbstractMetricSource.Holder<Holder> {
private final UuidGauge localNodeId = new UuidGauge(
"NodeId",
"Unique identifier of the local node",
- () -> physicalTopology.localMember().id());
+ localNode::id);
private final StringGauge localNodeName = new StringGauge(
"NodeName",
"Unique name of the local node",
- () -> physicalTopology.localMember().name());
+ localNode::name);
private final StringGauge networkAddress = new StringGauge(
"NetworkAddress",
"Network address of the local node",
- () -> {
- NetworkAddress addr =
physicalTopology.localMember().address();
- return addr != null ? addr.host() : "";
- });
+ () -> localNode.address().host());
Review Comment:
no, it can't be changed, I'm pretty sure the previous address could not also
be changed, how does that work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
