tmgodinho commented on code in PR #7844:
URL: https://github.com/apache/ignite-3/pull/7844#discussion_r3038965481
##########
modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientLazyTransaction.java:
##########
@@ -94,12 +105,35 @@ public void rollback() throws TransactionException {
public CompletableFuture<Void> rollbackAsync() {
var tx0 = tx;
+ // TODO: IGNITE-28405 This is really fishy. It will probably let you
reuse a transaction after calling a rollback :(
if (tx0 == null) {
// No operations were performed, nothing to rollback.
return nullCompletedFuture();
}
- return tx0.thenCompose(ClientTransaction::rollbackAsync);
+ // If the transaction is not started. Issue the rollback and wait for
the server response.
+ if (!tx0.isDone() && cancelled.compareAndSet(false, true)) {
+ return requestInfoFuture
+ .thenCompose(reqInfo -> {
+ ClientChannel ch = reqInfo.ch;
+ if
(ch.protocolContext().isFeatureSupported(TX_ROLLBACK_USING_FIRST_REQUEST)) {
+ return ch.serviceAsync(ClientOp.TX_ROLLBACK, w ->
w.out().packLong(-reqInfo.firstReqId), r -> null);
+ } else {
+ return NOT_SUPPORTED_FUTURE;
Review Comment:
The user will not see this future because it will be handled in the next
stage. Essentially, it will execute the `return
tx0.thenCompose(ClientTransaction::rollbackAsync);` immediately.
This is just an artifact to keep the code readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
