denis-chudov commented on code in PR #7931:
URL: https://github.com/apache/ignite-3/pull/7931#discussion_r3080704640
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -779,6 +779,20 @@ private void processMessageInternal(String sender,
PlacementDriverActorMessage m
clusterService.messagingService().respond(sender,
response, correlationId);
}
});
+ } else {
+ long time = lease.getLeaseholderId() == null
+ ? clockService.current().longValue()
+ : NULL_HYBRID_TIMESTAMP;
Review Comment:
This is the case when we get the message from node that is not a leaseholder.
The response may be important for actual leaseholder to know whether the
`stop lease prolongation` should be retried, it won't be retried if at lease
one node of placement driver group returned non null value.
If the node is not a current leaseholder, this means it shouldn't retry the
operation, so let's replace it with current time.
`getExpirationTime` doesn't make sense here because the lease may be
prolonged here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
