petrov-mg commented on code in PR #13101:
URL: https://github.com/apache/ignite/pull/13101#discussion_r3200407834
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTrackerTest.java:
##########
@@ -305,11 +304,16 @@ private void doTestTakeDumpByTime(
public void testMemoryLeakOnThreadTerminates() throws Exception {
int threadLimits = 1000;
int timeOutWorkerInterval = 10_000;
- Consumer<Set<PageLockThreadState>> hnd = (threads) -> {
- };
+ Consumer<Set<PageLockThreadState>> hnd = (threads) -> {};
Review Comment:
Done.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/GridUpdateNotifier.java:
##########
@@ -103,23 +104,21 @@ class GridUpdateNotifier {
this.updatesChecker = updatesChecker;
this.reportOnlyNew = reportOnlyNew;
- workerThread = new Thread(new Runnable() {
- @Override public void run() {
- try {
- while (!Thread.currentThread().isInterrupted()) {
- Runnable cmd0 = cmd.getAndSet(null);
+ workerThread = new IgniteThread(igniteInstanceName, "upd-ver-checker",
() -> {
+ try {
+ while (!Thread.currentThread().isInterrupted()) {
+ Runnable cmd0 = cmd.getAndSet(null);
- if (cmd0 != null)
- cmd0.run();
- else
- Thread.sleep(WORKER_THREAD_SLEEP_TIME);
- }
- }
- catch (InterruptedException ignore) {
- // No-op.
+ if (cmd0 != null)
+ cmd0.run();
+ else
+ Thread.sleep(WORKER_THREAD_SLEEP_TIME);
}
}
- }, "upd-ver-checker");
+ catch (InterruptedException ignore) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
